adding parts to the users guide regarding the Default guesser and guess_topologyAttributes #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
3 tasks
|
There is a conflict that needs to be resolved. I looked at it but I am not sure if the new text on guessers is supposed to be added to the other conflicting text or if it's supposed to (partially?) replace it. This requires an expert. |
|
@aya9aladdin can you find the time to resolve the conflicts in this PR? That would then allow us to have a look. It would be really good to have in-depth notes on the new guessers in the User Guide! |
|
I think I figured out how the conflict needed to be resolved (old guesser text went into DefaultGuesser) but please double check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding part to the universe page regarding the new guess_topologyAttributes
link: https://aya9aladdin.github.io/UserGuide/universe.html#guessing-topology-attributes
adding a new page for describing the guesser module and moving the guessers to a separate section called guessers list
link: https://aya9aladdin.github.io/UserGuide/formats/guessing.html