Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _FillValue attribute to most fields in MALI Registry #39

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

hollyhan
Copy link

@hollyhan hollyhan commented May 23, 2022

This PR adds cf-compliant default_value and missing_value attributes to MALI registry files.

@hollyhan hollyhan added the in progress Still being worked on, don't merge yet! label May 23, 2022
@hollyhan hollyhan removed the in progress Still being worked on, don't merge yet! label Oct 10, 2022
@xylar
Copy link

xylar commented Oct 11, 2022

@hollyhan, the other part of handling fill values will be creating an iceCellMask (or similar) integer variable of 0s and 1s that can be used with the work @cbegeman did in E3SM-Project#5154. This should presumably be a separate PR.

I'm wondering if it might make sense to work a few variables at a time rather than adding fill values to all variables at once. I think that's the strategy we ended up preferring by the end of the May hackathon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants