Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix layerNormalVelocity bug in Runge-Kutta loop #130

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix layerNormalVelocity bug in Runge-Kutta loop #130

wants to merge 2 commits into from

Commits on Oct 29, 2024

  1. Update layerNormalVelocity in each RK stage 

    Update layerNormalVelocity in each RK stage. While velocity was
being solved for each stage, layerNormalVelocity was not being
updated based on the updated velocity, which is a major bug.
    @trhille
    trhille committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    dc0d40c View commit details
    Browse the repository at this point in the history

  2. Use layerNormalVelocity to calculate layerThicknessEdge 

    Use layerNormalVelocity instead of normalVelocity to
calculate layerThicknessEdge.
    @trhille
    trhille committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    33e9a0b View commit details
    Browse the repository at this point in the history