Zero negative layerThickness along with negative thickness #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update layerThickness after negative thicknesses are set to zero. This is required for accurate treatment with Runge-Kutta time integration schemes.
| @@ -1189,6 +1190,7 @@ subroutine advection_solver(domain, err) | |||
| masktmp = 1 | |||
| thickness = 0.0_RKIND | |||
| end where | |||
| call li_calculate_layerThickness(meshPool, thickness, layerThickness) | |||
There was a problem hiding this comment.
Rather than recalculating layerThickness, what about setting layerThickness to zero wherever thickness gets set to zero? I know it should be safe to recalculate layerThickness at all the 'good' cells but it seems dangerous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update layerThickness after negative thicknesses are set to zero. This is required for accurate treatment with Runge-Kutta time integration schemes.