fix: remove logging #325
Merged
fix: remove logging #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codereviewbot-ai[bot]](https://avatars.githubusercontent.com/in/309638?s=60&v=4){kind=small}
| @@ -63,7 +63,7 @@ const runProxyRouter = (config) => { | |||
| "--log-level-scheduler=info", | |||
| "--log-level-proxy=info", | |||
| "--log-level-connection=info", | |||
| `--log-folder-path=${app.getPath("logs")}/`, | |||
| // `--log-folder-path=${app.getPath("logs")}/`, | |||
|
|
|||
| `--wallet-private-key=${config.privateKey}`, | |||
There was a problem hiding this comment.
The private key is being passed as a command line argument. This is a security risk because command line arguments can be viewed by any user on the system using commands like ps or by inspecting the /proc filesystem. It's recommended to use a more secure method to pass sensitive data, such as environment variables or secure files that are read by the application.
abs2023
previously approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.