Test, fix, and simplify ATR parsing #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ----- * Add `ATR.py` test cases. Code coverage of `ATR.py` is now 100%. * Add type annotations to everything in `ATR.py`. Changed ------- * `SmartcardException` will be raised if the ATR is less than 2 bytes. Fixed ----- * The ATR `checksumOK` attribute is now guaranteed to exist. If there is no checksum, `checksumOK` will be set to `None`. Previously, the attribute would only exist if a checksum existed. * The checksum byte will now always be rendered if it exists. Previously, if the checksum byte was `0x00`, it would not be rendered. Removed ------- * Remove the `__main__` code in `ATR.py`. All of the ATRs are present in the test suite. Deprecated ---------- * The ATR hasTA/hasTB/hasTC/hasTD attributes are deprecated. Users may compare items in the TA/TB/TC/TD attributes to `None`. * The ATR `dump()` method is deprecated. Users may call the new `render()` method and print the result.
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
ATR.pytest cases. Code coverage ofATR.pyis now 100%.ATR.py.Changed
SmartcardExceptionwill be raised if the ATR is less than 2 bytes.Fixed
The ATR
checksumOKattribute is now guaranteed to exist. If there is no checksum,checksumOKwill be set toNone.Previously, the attribute would only exist if a checksum existed.
The checksum byte will now always be rendered if it exists.
Previously, if the checksum byte was
0x00, it would not be rendered.Removed
Remove the
__main__code inATR.py.All of the ATRs are present in the test suite.
Deprecated
The ATR hasTA/hasTB/hasTC/hasTD attributes are deprecated.
Users may compare items in the TA/TB/TC/TD attributes to
None.The ATR
dump()method is deprecated.Users may call the new
render()method and print the result.