Support "64" as an ATR baud rate adjustment integer #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes LudovicRousseau#214 Changed ------- * Support "64" as an ATR baud rate adjustment integer (ISO 7816-3 2006). Removed ------- * Remove a trailing `"RFU"` value in the ATR clock rate mapping. Clock rates are mapped using only 4 bits, meaning there are only 16 possible values. The trailing `"RFU"` value was the 17th value in the list. Added ----- * Add a single test that trivially checks the ATR mapping lengths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #214
Changed
Removed
Remove a trailing
"RFU"value in the ATR clock rate mapping.Clock rates are mapped using only 4 bits, meaning there are only 16 possible values. The trailing
"RFU"value was the 17th value in the list.Added