Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CardNames #190

Closed
wants to merge 1 commit into from
Closed

Remove CardNames #190

wants to merge 1 commit into from

Conversation

kurtmckee
Copy link
Contributor

This PR introduces the following changes:

  • Remove CardNames, which depends on the Python 2-only bsddb module

Importing smartcard.CardNames results in a ModuleNotFoundError on Python 3.

@coveralls
Copy link

coveralls commented Sep 26, 2024 •
edited
Loading

Coverage Status

coverage: 60.484% (+0.4%) from 60.037%
when pulling 3088d78 on kurtmckee:rm-CardNames
into 1baa8ea on LudovicRousseau:master.

@LudovicRousseau
Copy link
Owner

merged in 51d1ccf

Thanks

@kurtmckee kurtmckee deleted the rm-CardNames branch September 27, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kurtmckee @coveralls @LudovicRousseau