Skip to content

Commit

Permalink
[SPARK-49868][DOC][FOLLOWUP] Update docs for executor failure trackin…
Browse files Browse the repository at this point in the history
…g configrations

### What changes were proposed in this pull request?

Previously, the executor failure tracking code was located at `ExecutorPodsAllocator`, which only takes effect when `spark.kubernetes.allocation.pods.allocator=direct`. apache#48344 moves the code to the `ExecutorPodsLifecycleManager`
consequently removes this limitation.

### Why are the changes needed?

Keep docs up-to-date with code.

### Does this PR introduce _any_ user-facing change?

Yes, docs are updated.

### How was this patch tested?

Review.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#48358 from pan3793/SPARK-49868-followup.

Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
  • Loading branch information
pan3793 authored and dongjoon-hyun committed Jan 7, 2025
1 parent bba8cf4 commit 194aa18
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1023,17 +1023,16 @@ package object config {
private[spark] val MAX_EXECUTOR_FAILURES =
ConfigBuilder("spark.executor.maxNumFailures")
.doc("The maximum number of executor failures before failing the application. " +
"This configuration only takes effect on YARN, or Kubernetes when " +
"`spark.kubernetes.allocation.pods.allocator` is set to 'direct'.")
"This configuration only takes effect on YARN and Kubernetes.")
.version("3.5.0")
.intConf
.createOptional

private[spark] val EXECUTOR_ATTEMPT_FAILURE_VALIDITY_INTERVAL_MS =
ConfigBuilder("spark.executor.failuresValidityInterval")
.doc("Interval after which executor failures will be considered independent and not " +
"accumulate towards the attempt count. This configuration only takes effect on YARN, " +
"or Kubernetes when `spark.kubernetes.allocation.pods.allocator` is set to 'direct'.")
"accumulate towards the attempt count. This configuration only takes effect on YARN " +
"and Kubernetes.")
.version("3.5.0")
.timeConf(TimeUnit.MILLISECONDS)
.createOptional
Expand Down
6 changes: 2 additions & 4 deletions docs/configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -565,8 +565,7 @@ of the most common options to set are:
<td>numExecutors * 2, with minimum of 3</td>
<td>
The maximum number of executor failures before failing the application.
This configuration only takes effect on YARN, or Kubernetes when
<code>spark.kubernetes.allocation.pods.allocator</code> is set to 'direct'.
This configuration only takes effect on YARN and Kubernetes.
</td>
<td>3.5.0</td>
</tr>
Expand All @@ -576,8 +575,7 @@ of the most common options to set are:
<td>
Interval after which executor failures will be considered independent and
not accumulate towards the attempt count.
This configuration only takes effect on YARN, or Kubernetes when
<code>spark.kubernetes.allocation.pods.allocator</code> is set to 'direct'.
This configuration only takes effect on YARN and Kubernetes.
</td>
<td>3.5.0</td>
</tr>
Expand Down

0 comments on commit 194aa18

Please sign in to comment.