Fix default values for parameter objects & insert semicolon after aut…

…ocomplete

The default values inserted when using autocomplete and parameter objects were not correct. for example, when you expect to get the number 0 you would instead get the string "Number".
i changed the code to handle the name and default separately before adding the newlines which did the trick.

Also added semicolons to autocomplete according to issue Mitcheljager#246
The semicolons are inserted only when autocompleting actions. having it add semicolons for other type of values could probably get annoying

Gemfile

@@ -59,7 +59,7 @@ group :development, :test do
   gem "rspec-rails", "~> 4.0.2"
   gem "selenium-webdriver", "~> 4.0"
   gem "shoulda-matchers", "~> 4.5"
-  gem "sqlite3", "1.4.2"
+  gem "sqlite3", "1.6.1"
   # To freeze time and allow time travel for time-sensitive tests
   gem "timecop"
   gem "webdrivers", "~> 5.0"

Gemfile.lock

@@ -466,7 +466,10 @@ GEM
       actionpack (>= 5.2)
       activesupport (>= 5.2)
       sprockets (>= 3.0.0)
-    sqlite3 (1.4.2)
+    sqlite3 (1.6.1)
+      mini_portile2 (~> 2.8.0)
+    sqlite3 (1.6.1-x64-mingw32)
+    sqlite3 (1.6.1-x86_64-linux)
     sucker_punch (3.0.1)
       concurrent-ruby (~> 1.0)
     sys-uname (1.2.2)
@@ -575,7 +578,7 @@ DEPENDENCIES
   selenium-webdriver (~> 4.0)
   sendgrid-ruby
   shoulda-matchers (~> 4.5)
-  sqlite3 (= 1.4.2)
+  sqlite3 (= 1.6.1)
   sucker_punch
   timecop
   turbolinks (~> 5)

app/javascript/src/components/editor/CodeMirror.svelte

@@ -17,6 +17,7 @@
   import { translationsMap } from "../../stores/translationKeys"
   import { getPhraseFromPosition } from "../../utils/parse"
   import { tabIndent, getIndentForLine, getIndentCountForText, shouldNextLineBeIndent, autoIndentOnEnter, indentMultilineInserts } from "../../utils/codemirror/indent"
+  import { get } from "svelte/store"
   import debounce from "../../debounce"
 
   const dispatch = createEventDispatcher()
@@ -70,7 +71,7 @@
         ]),
         EditorView.updateListener.of((transaction) => {
           if (transaction.docChanged) {
-            indentMultilineInserts(view, transaction)
+            autocompleteFormatting(view, transaction)
             updateItem()
           }
           if (transaction.selectionSet) $editorStates[currentId].selection = view.state.selection
@@ -165,6 +166,34 @@
     }
   }
 
+  function autocompleteFormatting(view, transaction) {
+    if (transaction.transactions.every(tr => ["input.complete"].includes(tr.annotation(Transaction.userEvent)))) {
+      indentMultilineInserts(view, transaction)
+      insertSemicolon(view, transaction)
+    }
+  }
+
+  function insertSemicolon(view, transaction) {
+    const line = view.state.doc.lineAt(transaction.changedRanges[0].fromB)
+    const phrase = getPhraseFromPosition(line, transaction.changedRanges[0].fromB)
+
+    const possibleValues = get(completionsMap).filter(v => v.args_length)
+    const validValue = possibleValues.find(v => v.label == phrase.text)
+
+    if (validValue?.type) {
+      const insertPosition = view.state.selection.ranges[0].from
+      
+      if(validValue.type === "function") {
+        view.dispatch({
+          changes: { from: insertPosition, insert: `;` },
+          selection: EditorSelection.create([
+            EditorSelection.range(insertPosition + 1, insertPosition + 1)
+          ])
+        })
+      }
+    }
+  }
+
   function click(event) {
     if (!event.altKey) return
 

app/javascript/src/components/editor/Editor.svelte

@@ -92,12 +92,13 @@
       const useNewlines = params.args_length >= $settings["autocomplete-min-parameter-newlines"]
 
       const apply = v.args.map(a => {
-        let string = a.default?.toString().toLowerCase().replaceAll(",", "")
-        if (useParameterObject) string = `${ useNewlines ? "\n\t" : "" }${ a.name }: ${ string }`
+        const name = toCapitalize(a.name?.toString().toLowerCase())
+        let defaultValue = a.default?.toString().toLowerCase().replaceAll(",", "")
+        defaultValue = lowercaseDefaults.includes(defaultValue.toLowerCase()) ?
+          defaults[toCapitalize(defaultValue)] :
+          toCapitalize(defaultValue)
 
-        if (lowercaseDefaults.includes(string)) return defaults[toCapitalize(string)]
-
-        return toCapitalize(string)
+        return useParameterObject ? `${useNewlines ? "\n\t" : ""}${name}: ${defaultValue}` : defaultValue
       })
 
       params.parameter_keys = detail