Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add update step for playwright system deps #1020

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeroengui
Copy link
Contributor

Type of change

Description:

The update process didn't include a step to update system dependencies for playwright. This caused errors when updating Lookyloo/playwright, without updating/installing the new dependencies.

image

Select the type of change(s) made in this pull request:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change or fix to documentation)

Proposed changes

  • add an extra step in the update.py process that runs playwright install-deps

@Rafiot
Copy link
Member

Rafiot commented Dec 19, 2024

This one is a bit annoying, because if running sudo for that user requires a password, it will block the update script, even if all the system dependencies are installed.

A clean way that I haven't found yet would be to check if all the required dependencies are installed (as user), and only run the install with sudo if they're not. This way, we don't block the update script most of the time.

@Rafiot Rafiot self-assigned this Dec 19, 2024
@jeroengui
Copy link
Contributor Author

I see, I only tested in on a system without sudo password, so this issue didn't occur to me.

The system dependencies for playwright don't seem to change often, so this also not a real priority.

Feel free to close the PR.

@Rafiot
Copy link
Member

Rafiot commented Dec 19, 2024

They don't change often, but when it fails, it's at runtime, generally on edge-cases for some browsers, so I'd like to find a solution.

I'll leave that one open for now so I don't forget about it and hopefully find a clean solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants