Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New page proposal : org : Team Listing Page #50

Closed
karankartikeya opened this issue Jun 17, 2020 · 14 comments
Closed

New page proposal : org : Team Listing Page #50

karankartikeya opened this issue Jun 17, 2020 · 14 comments
Labels
accepted frontend work related to frontend module:user related to users module

Comments

@karankartikeya
Copy link
Contributor

child issue of #48

Preview for the Team Listing Page:
https://codepen.io/karankartikeya/pen/QWyGGPy

Please Instruct for the changes to be made in it.

@lockedup-bot
Copy link

lockedup-bot bot commented Jun 17, 2020

Thanks @karankartikeya, for raising the issue! 🙌
One of our team mates will revert on this soon. ✅

@YashKumarVerma
Copy link
Member

something like https://bootsnipp.com/snippets/xpyz9

@YashKumarVerma YashKumarVerma added frontend work related to frontend module:user related to users module proposal proposal for task labels Jun 17, 2020
@karankartikeya
Copy link
Contributor Author

karankartikeya commented Jun 17, 2020

something like https://bootsnipp.com/snippets/xpyz9

@YashKumarVerma
Updated Preview for Team listing:
https://codepen.io/karankartikeya/pen/GRoNxGp

@YashKumarVerma
Copy link
Member

@karankartikeya Please check #45 and have a similar design. This way we can have a consistent design throughout the site.

@karankartikeya
Copy link
Contributor Author

@karankartikeya Please check #45 and have a similar design. This way we can have a consistent design throughout the site.

Ok sure

@karankartikeya
Copy link
Contributor Author

@karankartikeya Please check #45 and have a similar design. This way we can have a consistent design throughout the site.

Ok sure

@YashKumarVerma
Updated the Layout according to #45
link: https://codepen.io/karankartikeya/pen/GRoryKp

What are the other changes to be made?

@YashKumarVerma
Copy link
Member

#48 (comment)

@karankartikeya
Copy link
Contributor Author

@YashKumarVerma
Copy link
Member

Sorry to have confused you on this @karankartikeya , that was only an example of how the teams can be. it is not necessary that all teams will have things like science, commerce, and arts. 😆

Just keep everything same and add the following changes:

  • background color of card should be nothing / white
  • remove buttons which says science, com.etc
  • add the following details to the card:
    • date formed
    • total members

@karankartikeya
Copy link
Contributor Author

Sorry to have confused you on this @karankartikeya , that was only an example of how the teams can be. it is not necessary that all teams will have things like science, commerce, and arts.

Just keep everything same and add the following changes:

  • background color of card should be nothing / white

  • remove buttons which says science, com.etc

  • add the following details to the card:

    • date formed
    • total members

Updated the page according to the instructions and removed the background color as well as image.
https://codepen.io/karankartikeya/pen/gOPmNQN

@YashKumarVerma
Copy link
Member

Awesome ! Please send a PR for this

@karankartikeya
Copy link
Contributor Author

Sure,
I will send it in a moment.

@karankartikeya
Copy link
Contributor Author

Should i close the issue or there would be change of label first?

@YashKumarVerma YashKumarVerma added accepted and removed proposal proposal for task labels Jun 25, 2020
@YashKumarVerma
Copy link
Member

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted frontend work related to frontend module:user related to users module
Projects
None yet
Development

No branches or pull requests

2 participants