Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organization Module : Pages #48

Open
2 of 5 tasks
YashKumarVerma opened this issue Jun 17, 2020 · 14 comments
Open
2 of 5 tasks

Organization Module : Pages #48

YashKumarVerma opened this issue Jun 17, 2020 · 14 comments
Labels
frontend work related to frontend module:org Parent Issue gives brith to other issues

Comments

@YashKumarVerma
Copy link
Member

YashKumarVerma commented Jun 17, 2020

Available pages:

  • Organization Profile Page 🟢
  • Organization Profile Edit Page 🟢
  • Organization People listing page 🟢
  • Organizaition Team listing page 🟢
  • Organization Notifications Invitation Page 🟢

All pages have to be made in Bootstrap only.
To work on this,

  • Open issue with title : New page proposal : org : <page name>
  • Show layout of page by creating containers, rows, and columns by creating them in bootstrap, and share the code by uploading it on your personal github profile. All components should be inside respective cards.
  • Share the link of the file uploaded / html preview ( or using github pages) in the issue description.
  • Wait for approval.
  • Start working once approved.

What to do when accepted

As the frontend submissions are being done relatively fast right now, I've created a separate repository to keep all the work we have finalized. i.e. ready to be integrated.

Those submissions that have been marked as accepted, change the code links (script tags, link tags, image tags) to ensure the following points

  • Ensure that all css are there in assets/css
  • Ensure that all js are there in assets/js
  • Ensure that all images are there in assets/images
  • Ensure that all fonts are there in assets/fonts
  • Each module should have it's own folder. For example, user module must have it's files in /user directory.

and send a pull request to https://github.com/LockedUp-Coders/user-interface
Make a pull request only when your issue has been marked as "accepted"


How to close your child issue


Make sure that you add the text "Child of #48" in the issue body so that it is linked to this issue.

@lockedup-bot
Copy link

lockedup-bot bot commented Jun 17, 2020

Thanks @YashKumarVerma, for raising the issue! 🙌
One of our team mates will revert on this soon. ✅

@VershaCoder
Copy link
Member

@YashKumarVerma
What's the difference between Organization People listing page and the Organization Team listing page?

@YashKumarVerma
Copy link
Member Author

YashKumarVerma commented Jun 21, 2020

One school. Each year one class passes. like class of 2020, 2021, 2022... so each batch if a team.

There can be a team like 2020 Science, 2020 Commerce etc.

People = individual students.
@VershaCoder

@VershaCoder
Copy link
Member

Okay!! Thanks for the clarification. I think #50 needs to be updated as in that layout students are showing which is not correct. @YashKumarVerma what do you think?

@YashKumarVerma
Copy link
Member Author

Thanks for pointing out 👍

@hayat-tamboli
Copy link
Member

@YashKumarVerma can you give an example or some explanation of how the Organization Notifications Invitation Page would look like and what would it have.

@YashKumarVerma
Copy link
Member Author

Something like this @hayat-tamboli

Screenshot from 2020-06-22 02-40-13

@VershaCoder
Copy link
Member

has anyone started working on Organization People listing page?

@YashKumarVerma
Copy link
Member Author

has anyone started working on Organization People listing page?

I guess no. You can take that up @VershaCoder

@VershaCoder
Copy link
Member

Sure @YashKumarVerma

@VershaCoder
Copy link
Member

Sure @YashKumarVerma
@YashKumarVerma Could you please share the details that need to display.

@YashKumarVerma
Copy link
Member Author

Sure @YashKumarVerma
@YashKumarVerma Could you please share the details that need to display.

Just simple user profile cards. Normal details of user, check user schema file for it

@hayat-tamboli
Copy link
Member

@YashKumarVerma as nobody is actively working on Organization People listing page, shall I make this page.

@VershaCoder
Copy link
Member

@YashKumarVerma as nobody is actively working on Organization People listing page, shall I make this page.

I have almost done, will share the preview tomorrow. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend work related to frontend module:org Parent Issue gives brith to other issues
Projects
None yet
Development

No branches or pull requests

3 participants