Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend- adinalini.js #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adinalini
Copy link

Completed the task to join backend team.

@vivekshah1801
Copy link
Contributor

Hello @adinalini

here the function getMonths() + 1 will return the month's number.
i.e. 3 for April, 0 for January.

We want the month name, not the number.

@vivekshah1801
Copy link
Contributor

It is good practice to log that the app is started.

app.listen(port, () => {
// console log here
})

@adinalini
Copy link
Author

adinalini commented Jun 11, 2020

We want the month name, not the number.

Ah yeah, thanks for pointing it out.

It is good practice to log that the app is started.

Thanks, I just started yesterday with express, have no prior experience, will keep in mind 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants