Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add method for setting new topology #36

Merged
merged 5 commits into from
May 16, 2024

Conversation

FrogTheFrog
Copy link
Collaborator

@FrogTheFrog FrogTheFrog commented May 15, 2024

Description

Add method for setting new topology.

I had to reduce the amount of usbmmidd VDDs as apparently they sometimes cause what I would guess is a BSOD - the test just dies and workflow cannot be canceled.

I would assume this is a driver issue, since I have verified that it dies after the call to ::SetDisplayConfig.
I have even verified that the paths provided to ::SetDisplayConfig are valid with the SDC_VALIDATE flag which tells me that Windows is happy with the provided new paths. However, if you try to actually apply those paths, it will sometimes fail.

I have also tried installing usbmmidd VDDs and the more you install, the less the system becomes stable as a whole, so I'm inclined to believe that Windows is not happy about these VDDs...

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 96.22642% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 87.09%. Comparing base (842658f) to head (6200e43).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   86.09%   87.09%   +1.00%     
==========================================
  Files          10       10              
  Lines         568      620      +52     
  Branches      308      339      +31     
==========================================
+ Hits          489      540      +51     
- Misses         44       45       +1     
  Partials       35       35              
Flag Coverage Δ
Linux 84.37% <ø> (ø)
Windows 87.09% <96.22%> (+1.00%) ⬆️
macOS 51.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...clude/displaydevice/windows/winapilayerinterface.h 100.00% <ø> (ø)
.../displaydevice/windows/windisplaydeviceinterface.h 100.00% <ø> (ø)
src/windows/winapiutils.cpp 99.37% <100.00%> (+<0.01%) ⬆️
src/windows/windisplaydevicetopology.cpp 98.87% <100.00%> (+1.05%) ⬆️
src/windows/winapilayer.cpp 77.85% <75.00%> (+0.18%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Member

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no useful feedback for this one.

tests/unit/windows/utils/comparison.cpp Outdated Show resolved Hide resolved
tests/unit/windows/utils/comparison.h Outdated Show resolved Hide resolved
tests/unit/windows/utils/guards.h Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@FrogTheFrog
Copy link
Collaborator Author

I have no useful feedback for this one.

Still, thank you for the review!

@ReenigneArcher ReenigneArcher merged commit b24f93a into LizardByte:master May 16, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants