-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add method for setting new topology #36
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #36 +/- ##
==========================================
+ Coverage 86.09% 87.09% +1.00%
==========================================
Files 10 10
Lines 568 620 +52
Branches 308 339 +31
==========================================
+ Hits 489 540 +51
- Misses 44 45 +1
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no useful feedback for this one.
Co-authored-by: ReenigneArcher <[email protected]>
Still, thank you for the review! |
Description
Add method for setting new topology.
I had to reduce the amount of
usbmmidd
VDDs as apparently they sometimes cause what I would guess is a BSOD - the test just dies and workflow cannot be canceled.I would assume this is a driver issue, since I have verified that it dies after the call to
::SetDisplayConfig
.I have even verified that the paths provided to
::SetDisplayConfig
are valid with theSDC_VALIDATE
flag which tells me that Windows is happy with the provided new paths. However, if you try to actually apply those paths, it will sometimes fail.I have also tried installing
usbmmidd
VDDs and the more you install, the less the system becomes stable as a whole, so I'm inclined to believe that Windows is not happy about these VDDs...Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.