Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Port more Windows API utils #32

Merged
merged 4 commits into from
May 11, 2024

Conversation

FrogTheFrog
Copy link
Collaborator

Description

Ported more utils from Sunshine PR.
Also renamed the winutils -> winapiutils as I've realized that later on the file will grow too big. Did not change the namespace though since I plan to reuse it.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 88.50575% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 76.01%. Comparing base (d3c25ba) to head (5076d7e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   74.87%   76.01%   +1.14%     
==========================================
  Files          11       11              
  Lines         394      442      +48     
  Branches      221      250      +29     
==========================================
+ Hits          295      336      +41     
+ Misses         38       37       -1     
- Partials       61       69       +8     
Flag Coverage Δ
Linux 78.72% <ø> (ø)
Windows 76.94% <88.50%> (+1.07%) ⬆️
macOS 51.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/windows/include/displaydevice/windows/types.h 100.00% <100.00%> (ø)
src/windows/windisplaydevicetopology.cpp 84.61% <ø> (ø)
src/windows/winapiutils.cpp 88.37% <88.37%> (ø)

... and 1 file with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit d6c21b1 into LizardByte:master May 11, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants