Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(win_api_layer): add implicit flag validation for setDisplayConfig #130

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

FrogTheFrog
Copy link
Collaborator

Description

Implicitly check whether setDisplayConfig will succeed with the default flags.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.36%. Comparing base (2c431bc) to head (957ae65).

Files with missing lines Patch % Lines
src/windows/win_api_layer.cpp 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   94.34%   94.36%   +0.02%     
==========================================
  Files          34       34              
  Lines        2015     2024       +9     
  Branches     1041     1043       +2     
==========================================
+ Hits         1901     1910       +9     
- Misses         51       58       +7     
+ Partials       63       56       -7     
Flag Coverage Δ
Linux 93.03% <ø> (+1.81%) ⬆️
Windows 94.19% <93.33%> (+0.02%) ⬆️
macOS 75.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...e/display_device/windows/win_api_layer_interface.h 100.00% <ø> (ø)
src/windows/win_api_layer.cpp 79.39% <93.33%> (+0.52%) ⬆️

... and 1 file with indirect coverage changes

@@ -182,7 +182,7 @@ jobs:
# Doxygen from Ubuntu is too old, need Doxygen >= 1.10
DOCS=OFF
else
DOCS=ON
DOCS=OFF
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this for now. My other PR won't be so easy since it still installs Doxygen 1.13 on macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants