Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codecov): add retry logic to codecov collection #67

Merged

Conversation

ReenigneArcher
Copy link
Member

Description

Another attempt to fix codecov failures.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (4)

src/updater.py:48

  • [nitpick] The variable name 'max_tries' is not very descriptive. Consider renaming it to 'max_retries' for better clarity.
max_tries = 5

src/updater.py:49

  • [nitpick] The variable name 'count' is not very descriptive. Consider renaming it to 'retry_count' for better clarity.
count = 0

src/updater.py:61

  • The error message raised when 'data' is not available is not very descriptive. Consider including more context in the error message.
raise requests.exceptions.HTTPError(f'Error: {response.text}')

src/updater.py:52

  • Ensure that the retry logic and exponential backoff are covered by tests.
while count < max_tries:
@ReenigneArcher ReenigneArcher force-pushed the fix/codecov/add-retry-logic-to-codecov-collection branch from 800f35c to 0960cf2 Compare December 22, 2024 01:04
@ReenigneArcher ReenigneArcher merged commit 98e141d into master Dec 22, 2024
9 checks passed
@ReenigneArcher ReenigneArcher deleted the fix/codecov/add-retry-logic-to-codecov-collection branch December 22, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

codecov regularly fails to update
1 participant