Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(notebook): move code to standard python #30

Merged

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Sep 3, 2024

Description

Moving the code to standard python will enable several things.

  1. Simplify update and notebook generation
  2. Unit testing and coverage
  3. Easier PR reviews (notebook diffs are stupid)

Todo:

  • Save data to gh-pages where possible in json format

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher ReenigneArcher force-pushed the refactor/notebook/move-code-to-standard-python branch 6 times, most recently from 9599dc6 to f2ba77d Compare September 3, 2024 22:51
@ReenigneArcher ReenigneArcher force-pushed the refactor/notebook/move-code-to-standard-python branch from f2ba77d to 555f296 Compare September 3, 2024 23:04
Copy link

sonarqubecloud bot commented Sep 3, 2024

@ReenigneArcher ReenigneArcher marked this pull request as ready for review September 3, 2024 23:09
@ReenigneArcher ReenigneArcher enabled auto-merge (squash) September 3, 2024 23:10
@ReenigneArcher ReenigneArcher merged commit 9e13db3 into master Sep 3, 2024
8 checks passed
@ReenigneArcher ReenigneArcher deleted the refactor/notebook/move-code-to-standard-python branch September 3, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant