Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(gh-pages): migrate site to jekyll format #169

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Jan 5, 2025

Description

This PR moves the product page over to the upcoming Jekyll style.

TODO:

Screenshot

image

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher ReenigneArcher force-pushed the docs/gh-pages/migrate-site-to-jekyll-format branch 2 times, most recently from e2986c4 to eb79bdb Compare January 5, 2025 23:53
.github/workflows/update-db.yml Outdated Show resolved Hide resolved
.github/workflows/update-db.yml Outdated Show resolved Hide resolved
@ReenigneArcher ReenigneArcher requested a review from Copilot January 5, 2025 23:55

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • gh-pages-template/index.html: Language not supported
Comments suppressed due to low confidence (2)

gh-pages-template/assets/js/item_loader.js:9

  • The variable 'platforms_container' was previously declared without 'let'. Ensure that this change does not cause issues with its usage elsewhere in the code.
let platforms_container = document.getElementById("platforms-container")

gh-pages-template/assets/js/item_loader.js:339

  • The changes to the script loading sequence in the 'initialize' function should be covered by tests to ensure the new order does not introduce any issues.
initialize()
@ReenigneArcher ReenigneArcher force-pushed the docs/gh-pages/migrate-site-to-jekyll-format branch from eb79bdb to 82a8a61 Compare January 7, 2025 03:03
Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
2 New issues
2 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@ReenigneArcher ReenigneArcher marked this pull request as ready for review January 7, 2025 03:06
@ReenigneArcher ReenigneArcher merged commit dd19307 into master Jan 7, 2025
11 of 12 checks passed
@ReenigneArcher ReenigneArcher deleted the docs/gh-pages/migrate-site-to-jekyll-format branch January 7, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant