Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: move code to src directory #166

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Jan 5, 2025

Description

This PR moves python source code to the src directory.

Additionally:

  • some commented out code was removed
  • workflow concurrency was added

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@ReenigneArcher ReenigneArcher force-pushed the style/move-code-to-src-directory branch from 6f7dde4 to 646716a Compare January 5, 2025 13:05
Copy link

sonarqubecloud bot commented Jan 5, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
1 New issue
1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@ReenigneArcher ReenigneArcher requested a review from Copilot January 5, 2025 13:07

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/update_db.py:17

  • The variable 'args' is not defined within the scope of the function 'write_json_files'. Consider passing 'args' as a parameter or defining 'indent' within the function.
json.dump(obj=data, fp=f, indent=args.indent)

src/update_db.py:3

  • The docstring for 'write_json_files' is missing the type for the 'data' parameter. It should specify that 'data' is a dictionary.
data
@ReenigneArcher ReenigneArcher merged commit 351555f into master Jan 5, 2025
9 of 10 checks passed
@ReenigneArcher ReenigneArcher deleted the style/move-code-to-src-directory branch January 5, 2025 13:31
@ReenigneArcher ReenigneArcher restored the style/move-code-to-src-directory branch January 5, 2025 13:32
@ReenigneArcher ReenigneArcher deleted the style/move-code-to-src-directory branch January 5, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant