WIP: twilio/sdk 8.x #21
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I suggest just to remove composer.json directly and vendor folder and make related changes in extension and just modify https://github.com/LiveHelperChat/livehelperchat/blob/master/lhc_web/composer.json and have composer depencendies in main composer.json file just. |
|
Hi @remdex I will do that. Thanks. |
|
It should be similar change to this. Where composer dependencies were moved to main app composer.json file and vendor files etc related changes were done in 2fa extension itself :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Starting the migration to Twilio SDK v8.x (minimum PHP 7.1).
I have only tested sending and receiving message with plain text. I still need to handle sending files and other additional information.
Thank you.