Skip to content

Commit

Permalink
Start addressing the return NULL issue detected by BiocCheck at https…
Browse files Browse the repository at this point in the history
  • Loading branch information
lcolladotor and Nick-Eagles committed Jul 24, 2024
1 parent 79d0853 commit 0c998f3
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 5 deletions.
3 changes: 2 additions & 1 deletion R/array_coord_utils.R
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#' @param coords A \code{tibble} containing 'array_row' and 'array_col' columns
#' calculated internally by \code{add_array_coords()}
#'
#' @return NULL
#' @return It returns `NULL` if all tests were correct.
#'
#' @author Nicholas J. Eagles
#' @keywords internal
Expand Down Expand Up @@ -45,6 +45,7 @@
if (any((coords$array_row == 0) & (coords$array_col == 0))) {
stop("Internal bug: the invalid array coordinate (0, 0) exists after fitting")
}
return(insivible(NULL))
}

#' Return array coordinates fit to nearest spot with associated error
Expand Down
3 changes: 2 additions & 1 deletion R/prep_fiji_coords.R
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
#' the output pixel coordinates CSVs. Provided the parent exists, \code{out_dir}
#' will be created if necessary.
#'
#' @return NULL
#' @return This function returns `character()` with the file paths to the
#' `tissue_positions.csv` files it created.
#'
#' @import xml2
#' @importFrom stringr str_replace_all str_detect
Expand Down
3 changes: 2 additions & 1 deletion R/prep_fiji_image.R
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
#' pixels) of the larger dimension of the output image(s), considered to be "low
#' resolution".
#'
#' @return NULL
#' @return This function returns `character()` with the file paths to the
#' `tissue_lowres_image.png` and `scalefactors_json.json` files it created.
#'
#' @importFrom imager load.image resize save.image
#' @importFrom rjson fromJSON toJSON
Expand Down
2 changes: 1 addition & 1 deletion R/spe_to_seurat.R
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
#' @param verbose A logical(1) vector. If true, print status updates about the
#' conversion process
#'
#' @return A \code{Seurat} object
#' @return A \code{Seurat} object.
#'
#' @export
#' @author Nicholas J. Eagles
Expand Down
3 changes: 3 additions & 0 deletions man/dot-validate_array.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions man/prep_fiji_coords.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions man/prep_fiji_image.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/spe_to_seurat.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 0c998f3

Please sign in to comment.