Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use fallback to get page dimension #4459

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

vitormattos
Copy link
Member

@vitormattos vitormattos commented Jan 24, 2025

@vitormattos vitormattos added this to the Next Major (31) milestone Jan 24, 2025
@vitormattos vitormattos self-assigned this Jan 24, 2025
@vitormattos vitormattos marked this pull request as draft January 24, 2025 01:39
@vitormattos vitormattos force-pushed the chore/use-fallback-to-get-page-dimension branch from 9ec1a03 to de542dd Compare January 24, 2025 19:09
@vitormattos
Copy link
Member Author

The solution using smalot/pdfparser didn't worked fine and was replaced by pdfinfo from poppler utils as fallback.

@vitormattos vitormattos force-pushed the chore/use-fallback-to-get-page-dimension branch 2 times, most recently from 4814919 to fc7ec31 Compare January 25, 2025 11:42
@vitormattos vitormattos marked this pull request as ready for review January 25, 2025 11:42
@vitormattos vitormattos force-pushed the chore/use-fallback-to-get-page-dimension branch from fc7ec31 to c129b34 Compare January 25, 2025 11:56
@vitormattos
Copy link
Member Author

/backport to stable30

@vitormattos
Copy link
Member Author

/backport to stable29

@vitormattos vitormattos merged commit c4b306e into main Jan 25, 2025
61 checks passed
@vitormattos vitormattos deleted the chore/use-fallback-to-get-page-dimension branch January 25, 2025 12:08
@vitormattos vitormattos removed this from the Next Major (31) milestone Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 4. to release
Development

Successfully merging this pull request may close these issues.

Libresign and Nextcloud: error during configuration step of a sign on a pdf file
1 participant