Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate from uploaded file #4239

Merged
merged 101 commits into from
Jan 9, 2025
Merged

Conversation

vitormattos
Copy link
Member

@vitormattos vitormattos commented Jan 3, 2025

Dependency added:

  • poppler-utils

Was added as fallback to native PHP signature parser.

🏚️ Before 🏑 After
Screenshot_20250102_233051 Screenshot_20250102_232935
Screenshot_20250110_105306 Screenshot_20250106_231154
Screenshot_20250110_105159 Screenshot_20250106_231009

to-do

  • Implement upload at frontend
  • Create endpoint
  • Add integration tests
  • Match uploaded file with existing files
  • Display data from uploaded file when not matched with existing files
  • Display that have a newest version of uploaded file
  • Details about signer
    • Sign date
    • Certificate chain
  • Show more details about file
    • File size
    • Page counter
    • PDF version
    • Has the file been changed after signing?
    • PDF metadata
    • Signature hash used
    • Load certificate chain using poppler-utils

@vitormattos vitormattos added this to the Next Major (31) milestone Jan 3, 2025
@vitormattos vitormattos self-assigned this Jan 3, 2025
@vitormattos vitormattos changed the title Feat/validate from uploaded file feat: validate from uploaded file Jan 3, 2025
@vitormattos vitormattos force-pushed the feat/validate-from-uploaded-file branch 2 times, most recently from f1d04db to c023f35 Compare January 4, 2025 13:01
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Is necessary to identify the file to parse from UUID.

Signed-off-by: Vitor Mattos <[email protected]>
A step to be possible choose what kind of metadata I want

Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos vitormattos force-pushed the feat/validate-from-uploaded-file branch from 1ecff7b to afd602a Compare January 6, 2025 23:37
@vitormattos vitormattos force-pushed the feat/validate-from-uploaded-file branch from 49ac7fb to 784b751 Compare January 8, 2025 17:54
removed typo that was added to be possible validate when pdfsig don't
exists

Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
Copy link
Member Author

/backport to stable30

@vitormattos
Copy link
Member Author

/backport to stable29

@vitormattos vitormattos merged commit 9d70396 into main Jan 9, 2025
57 checks passed
@vitormattos vitormattos deleted the feat/validate-from-uploaded-file branch January 9, 2025 16:32
@backportbot-libresign
Copy link

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/4239/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 1002f105 24a887af 75267492 11f16b14 f900fa83 214f4c27 859df10c 92aa3ddc 07d39d3b af51c3d1 054d0e53 d013ffb6 16dd18cf 9fa09107 4dcdb18e fb88965b 756263de db126976 0079f3c2 7e2f74d0 78d7ad15 9d5cb1f2 574e4ec3 8dd6d5ad 04feb06d a1dc48b8 97b9a224 5322fc0c 70e03c59 a139447f

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/4239/stable29

Error: Failed to push branch backport/4239/stable29: fatal: could not read Username for 'https://github.com': No such device or address


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@vitormattos
Copy link
Member Author

/backport to stable29

@backportbot-libresign
Copy link

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/4239/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 1002f105 24a887af 75267492 11f16b14 f900fa83 214f4c27 859df10c 92aa3ddc 07d39d3b af51c3d1 054d0e53 d013ffb6 16dd18cf 9fa09107 4dcdb18e fb88965b 756263de db126976 0079f3c2 7e2f74d0 78d7ad15 9d5cb1f2 574e4ec3 8dd6d5ad 04feb06d a1dc48b8 97b9a224 5322fc0c 70e03c59 a139447f

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/4239/stable29

Error: Failed to push branch backport/4239/stable29: fatal: could not read Username for 'https://github.com': No such device or address


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 4. to release
Development

Successfully merging this pull request may close these issues.

1 participant