Merge pull request #4266 from LibreSign/fix/path-of-renew-url

fix: path of renew url
LibreSign · Jan 13, 2025 · da01a27 · da01a27
2 parents 43f24e0 + 1ac6f7e
commit da01a27
Show file tree

Hide file tree

Showing 5 changed files with 42 additions and 22 deletions.
diff --git a/lib/Controller/PageController.php b/lib/Controller/PageController.php
@@ -245,7 +245,7 @@ public function signFPath(string $uuid): TemplateResponse {
 	}
 
 	/**
-	 * Sign page to authenticated signer
+	 * Sign page to unauthenticated signer
 	 *
 	 * The path is used only by frontend
 	 *
@@ -259,13 +259,13 @@ public function signFPath(string $uuid): TemplateResponse {
 	#[RequireSetupOk]
 	#[PublicPage]
 	#[RequireSignRequestUuid]
-	#[FrontpageRoute(verb: 'GET', url: '/p/sign/{uuid}/pdf')]
-	public function signPdf(string $uuid): TemplateResponse {
+	#[FrontpageRoute(verb: 'GET', url: '/p/sign/{uuid}/{path}', requirements: ['path' => '.+'])]
+	public function signPPath(string $uuid): TemplateResponse {
 		return $this->sign($uuid);
 	}
 
 	/**
-	 * Sign page to authenticated signer
+	 * Sign page to unauthenticated signer
 	 *
 	 * The path is used only by frontend
 	 *

diff --git a/openapi-full.json b/openapi-full.json
@@ -1290,10 +1290,10 @@
                 }
             }
         },
-        "/index.php/apps/libresign/p/sign/{uuid}/pdf": {
+        "/index.php/apps/libresign/p/sign/{uuid}/{path}": {
             "get": {
-                "operationId": "page-sign-pdf",
-                "summary": "Sign page to authenticated signer",
+                "operationId": "page-signp-path",
+                "summary": "Sign page to unauthenticated signer",
                 "description": "The path is used only by frontend",
                 "tags": [
                     "page"
@@ -1316,6 +1316,15 @@
                         "schema": {
                             "type": "string"
                         }
+                    },
+                    {
+                        "name": "path",
+                        "in": "path",
+                        "required": true,
+                        "schema": {
+                            "type": "string",
+                            "pattern": "^.+$"
+                        }
                     }
                 ],
                 "responses": {
@@ -1335,7 +1344,7 @@
         "/index.php/apps/libresign/p/sign/{uuid}": {
             "get": {
                 "operationId": "page-sign",
-                "summary": "Sign page to authenticated signer",
+                "summary": "Sign page to unauthenticated signer",
                 "description": "The path is used only by frontend",
                 "tags": [
                     "page"

diff --git a/openapi.json b/openapi.json
@@ -1194,10 +1194,10 @@
                 }
             }
         },
-        "/index.php/apps/libresign/p/sign/{uuid}/pdf": {
+        "/index.php/apps/libresign/p/sign/{uuid}/{path}": {
             "get": {
-                "operationId": "page-sign-pdf",
-                "summary": "Sign page to authenticated signer",
+                "operationId": "page-signp-path",
+                "summary": "Sign page to unauthenticated signer",
                 "description": "The path is used only by frontend",
                 "tags": [
                     "page"
@@ -1220,6 +1220,15 @@
                         "schema": {
                             "type": "string"
                         }
+                    },
+                    {
+                        "name": "path",
+                        "in": "path",
+                        "required": true,
+                        "schema": {
+                            "type": "string",
+                            "pattern": "^.+$"
+                        }
                     }
                 ],
                 "responses": {
@@ -1239,7 +1248,7 @@
         "/index.php/apps/libresign/p/sign/{uuid}": {
             "get": {
                 "operationId": "page-sign",
-                "summary": "Sign page to authenticated signer",
+                "summary": "Sign page to unauthenticated signer",
                 "description": "The path is used only by frontend",
                 "tags": [
                     "page"

diff --git a/src/types/openapi/openapi-full.ts b/src/types/openapi/openapi-full.ts
@@ -153,18 +153,18 @@ export type paths = {
         patch?: never;
         trace?: never;
     };
-    "/index.php/apps/libresign/p/sign/{uuid}/pdf": {
+    "/index.php/apps/libresign/p/sign/{uuid}/{path}": {
         parameters: {
             query?: never;
             header?: never;
             path?: never;
             cookie?: never;
         };
         /**
-         * Sign page to authenticated signer
+         * Sign page to unauthenticated signer
          * @description The path is used only by frontend
          */
-        get: operations["page-sign-pdf"];
+        get: operations["page-signp-path"];
         put?: never;
         post?: never;
         delete?: never;
@@ -181,7 +181,7 @@ export type paths = {
             cookie?: never;
         };
         /**
-         * Sign page to authenticated signer
+         * Sign page to unauthenticated signer
          * @description The path is used only by frontend
          */
         get: operations["page-sign"];
@@ -1510,13 +1510,14 @@ export interface operations {
             };
         };
     };
-    "page-sign-pdf": {
+    "page-signp-path": {
         parameters: {
             query?: never;
             header?: never;
             path: {
                 /** @description Sign request uuid */
                 uuid: string;
+                path: string;
             };
             cookie?: never;
         };

diff --git a/src/types/openapi/openapi.ts b/src/types/openapi/openapi.ts
@@ -153,18 +153,18 @@ export type paths = {
         patch?: never;
         trace?: never;
     };
-    "/index.php/apps/libresign/p/sign/{uuid}/pdf": {
+    "/index.php/apps/libresign/p/sign/{uuid}/{path}": {
         parameters: {
             query?: never;
             header?: never;
             path?: never;
             cookie?: never;
         };
         /**
-         * Sign page to authenticated signer
+         * Sign page to unauthenticated signer
          * @description The path is used only by frontend
          */
-        get: operations["page-sign-pdf"];
+        get: operations["page-signp-path"];
         put?: never;
         post?: never;
         delete?: never;
@@ -181,7 +181,7 @@ export type paths = {
             cookie?: never;
         };
         /**
-         * Sign page to authenticated signer
+         * Sign page to unauthenticated signer
          * @description The path is used only by frontend
          */
         get: operations["page-sign"];
@@ -1364,13 +1364,14 @@ export interface operations {
             };
         };
     };
-    "page-sign-pdf": {
+    "page-signp-path": {
         parameters: {
             query?: never;
             header?: never;
             path: {
                 /** @description Sign request uuid */
                 uuid: string;
+                path: string;
             };
             cookie?: never;
         };