Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace type comments with type annotations #130

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

rnestler
Copy link
Member

Also correct type annotations where needed and remove them were the type can be inferred.

@rnestler rnestler requested a review from dbrgn May 20, 2024 14:10
@rnestler rnestler self-assigned this May 20, 2024
entities/component.py Show resolved Hide resolved
entities/component.py Show resolved Hide resolved
generate_chip.py Show resolved Hide resolved
@rnestler rnestler force-pushed the replace-type-comments branch from c72ba44 to 3c7240f Compare May 20, 2024 14:12
Also correct type annotations where needed and remove them were the type
can be inferred.
@rnestler rnestler force-pushed the replace-type-comments branch from 3c7240f to 01fd55b Compare May 20, 2024 14:16
@rnestler rnestler enabled auto-merge (squash) May 20, 2024 14:22
@rnestler rnestler requested a review from a team May 20, 2024 14:22
Copy link
Member

@dbrgn dbrgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rnestler rnestler merged commit d6eede5 into master May 20, 2024
8 checks passed
@rnestler rnestler deleted the replace-type-comments branch May 20, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants