Merge pull request #11 from jdneo/cs/fix

fix #10
LeetCode-OpenSource · Feb 24, 2018 · 8ea762c · 8ea762c
2 parents feae070 + 5e67942
commit 8ea762c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,9 @@ Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how
 ### Added
 - Support setting the default language to solve problems [(#5)](https://github.com/jdneo/vscode-leetcode/issues/5)
 
+### Fixed
+- When user cancels login, no further actions will happen [(#10)](https://github.com/jdneo/vscode-leetcode/issues/10)
+
 ## [0.1.2]
 ### Fixed
 - Fix the deplicated nodes in LeetCode Explorer bug [(#6)](https://github.com/jdneo/vscode-leetcode/issues/6)

diff --git a/src/leetCodeManager.ts b/src/leetCodeManager.ts
@@ -59,7 +59,7 @@ class LeetCodeManager extends EventEmitter implements ILeetCodeManager {
                 });
                 if (!name) {
                     childProc.kill();
-                    resolve(undefined);
+                    return resolve(undefined);
                 }
                 childProc.stdin.write(`${name}\n`);
                 const pwd: string | undefined = await vscode.window.showInputBox({
@@ -69,7 +69,7 @@ class LeetCodeManager extends EventEmitter implements ILeetCodeManager {
                 });
                 if (!pwd) {
                     childProc.kill();
-                    resolve(undefined);
+                    return resolve(undefined);
                 }
                 childProc.stdin.write(`${pwd}\n`);
                 childProc.stdin.end();