Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Celo App Update #21

Merged
merged 82 commits into from
Aug 22, 2024
Merged

Celo App Update #21

merged 82 commits into from
Aug 22, 2024

Conversation

Z4karia
Copy link
Contributor

@Z4karia Z4karia commented Jul 24, 2024

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

@keiff3r
test: write test for get address with ethereum derivation path
4a24915
@keiff3r
feat: Add Ethereum paths to Makefile
e657cdf
@keiff3r
chore: generate golden path snapshot for the new test
43f850c
@keiff3r
test: write tests to validate using ethereum derivation path
3ad5c5b
@keiff3r
chore: generate screens to validate tests (for ethereum derivation path)
2afc50f
@keiff3r
fix: Update ETH_PACKED_DERIVATION_PATH in celo_utils.py
7755d03 
changed the format from 5 derivation to 3 derivations
@keiff3r
chore: Update test snapshots for Ethereum path derivation
2ea6740
@keiff3r
refactor: change eth support implementation
8fb5be2
@keiff3r
fix: add eth derivation path to match ci
f4cd02f
@keiff3r
refactor: change implementation of eth support
3fc8b41
@keiff3r
feat: enable optimisation, remove support for eth path
347004e
@keiff3r
feat: add Ethereum path in Makefile
682c7ef
@keiff3r
chore: generate new test snapshots for nanosp, nano X and stax
9d4a256
@keiff3r
fix(celo.c): add multiple breaks to remove a warning
857a4e7
@keiff3r
fix: Update cx_keccak_init calls to cx_keccak_init_no_throw
8d2786e
@keiff3r
fix: Update ticker and feeTicker to const char pointers
2f2f601
@keiff3r
fix: change cx_hash to cx_hash_no_throw
d69cb3b
@keiff3r
fix: change os_perso_derive_node_bip32 calls to os_derive_bip32_no_throw
cd2a5c8
@keiff3r
fix: remove all 'warn_unused_result' warnings
2c3e39a
@keiff3r
fix: change all deprecated functions calls with recommanded functions
c6e7b83
@keiff3r
feat: create structure to add support for EIP159 & CIP64 without brea…
2e805ac 
…king tests
@keiff3r
test: implement test for eip 1559 and generate golden snapshots
a6ef27e
@keiff3r
feat: prevent signing with other chain_ids but Celo's
3ea3b16
@keiff3r
refactor: rename a test and generate screenshots accordingly
1eb83d2
@keiff3r
fix: add case where chainID is null (to pass ci[Clang Static Analyzer]
ed2062f
@keiff3r
fix: add MIN macro to ethUstream.h and change include order in ethUst…
e80516b 
…ream.c
@keiff3r
fix: add return statement to processAccessList and processAndDiscard …
3491b7f 
…functions
@keiff3r
fix(unit_test): Update txType to CELO_LEGACY in unit test
410c076
@keiff3r
chore: Update app_celo.gif files
1352a74
@keiff3r
test: rename file and add test structure for cip64
0666526
keiff3r and others added 20 commits June 4, 2024 18:28
@keiff3r
Merge pull request #7 from blooo-io/refactor/update-public-key-to-ver…
5a0535e 
…ify-fee-currency

Refactor: update public key used to verify fee currency
@keiff3r
chore: remove dead code
18ef303
@keiff3r
fix: add guard for all processing function
c391bc9
@keiff3r
fix: add constants for status code
92b6e7a
@keiff3r
fix: replace harcoded SW with constants
8b9b78e
@n4l5u0r
fix: version bump
8f6309e
@n4l5u0r
Merge branch 'develop' into fix/audit-fix
6363186
@keiff3r
fix: add checks for null pointer context
4b36daa
@keiff3r
docs: add comments to celo.h
c8965b6
@keiff3r
docs: add comments to ethUstream.c
f797506
@keiff3r
docs: add comments to rlp.h
9ef6212
@keiff3r
docs: add comments for utils.h
a1da535
@keiff3r
docs: add comments for main.c
1f3047d
@keiff3r
fix: remove duplicate key in .clang-format
97a0575
@keiff3r
Merge pull request #8 from blooo-io/fix/audit-fix
7781402 
Fix vulnerability reported from the audit
@keiff3r
refactor: edit transaction sub-procesning functions and make changes …
ff1f368 
…accordingly
@keiff3r
chore: bump version
b50907c
@keiff3r
Merge pull request #9 from blooo-io/refactor/edit-sub-processing-func…
a1d0c73 
…tion

Refactor: edit transactions' sub-processing functions
@Z4karia
fix: changed stax touch to swipe
5f48303
@Z4karia
Merge pull request #10 from blooo-io/fix/stax-interface-update-add-swipe
08cf0a7 
fix: changed stax touch to swipe
@aaronmgdr aaronmgdr mentioned this pull request Jul 26, 2024
Open
1 task
@aaronmgdr
Copy link

aaronmgdr commented Jul 29, 2024 •
edited
Loading

cant wait for this one 🥳

@aaronmgdr
Copy link

@Z4karia looks like there are merge conflicts :(

@agrojean-ledger agrojean-ledger merged commit b58e214 into LedgerHQ:develop Aug 22, 2024
28 checks passed
@Z4karia Z4karia mentioned this pull request Aug 22, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrojean-ledger agrojean-ledger agrojean-ledger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Z4karia @aaronmgdr @agrojean-ledger @keiff3r @n4l5u0r