feat(op-batcher): altda->ethda failover #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samlaf
force-pushed
the
samlaf/feat--op-batcher-altda-failover-to-ethda
branch
from
50e492c
to
80728ec
Compare
samlaf
force-pushed
the
samlaf/feat--op-batcher-altda-failover-to-ethda
branch
from
adfa7ce
to
61d7578
Compare
samlaf
changed the base branch from
develop
to
feat--multiframe-altda-channel
|
At the high level, it usually takes us about 1 hour to fix the problem |
bxue-l2
reviewed
Nov 13, 2024
| @@ -130,6 +134,10 @@ func (s *FakeDAServer) HandleGet(w http.ResponseWriter, r *http.Request) { | |||
|
|
|||
| func (s *FakeDAServer) HandlePut(w http.ResponseWriter, r *http.Request) { | |||
| time.Sleep(s.putRequestLatency) | |||
| if s.failoverCount > 0 { | |||
There was a problem hiding this comment.
what is the point to decrement failoverCount, then actually handle the put
There was a problem hiding this comment.
Is it just to simplify testing?
| ) | ||
|
|
||
| // TestBatcher_FailoverToEthDA_FallbackToAltDA tests that the batcher will failover to ethDA | ||
| // if the da-server returns 503, and then fallback to altDA once altDA is available again |
There was a problem hiding this comment.
we always try altda first for every dispersal, then retry for non-altDA after sufficient retry. Wording seems odd.
|
|
||
| countEthDACommitment := uint64(0) | ||
|
|
||
| // Most likely, sequence of blocks will be: altDA, ethDA, ethDA, altDA, altDA, altDA. |
There was a problem hiding this comment.
why most likely? And why two ethDA in a row, because we set failoverCount=2, but why altDA in the beginning?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plan is to upstream this to op's repo. Created here to get review from the team first.
This PR builds on top of the feat--multiframe-altda-channel changes (already upstreamed to op's repo, waiting for review there)
It contains 2 commits:
Right now failover is done to calldata txs because that was trivial whereas failing over to blobs or their auto mode that switches between blobs and calldata would need a nontrivial refactor and some thinking. Not sure its worth putting effort into this atm given that the whole point of failover is that it should happen very rarely and also not last very long, but let me know if you guys think otherwise.