rewards + sdk update #9
Conversation
supernovahs
commented
Oct 22, 2024
•
supernovahs
commented
- update eigensdk
- Remove state dump
- Improve scripts
- Reward scripts
…rewards-programmatic-incentives
| @@ -0,0 +1,54 @@ | |||
| // SPDX-License-Identifier: UNLICENSED | |||
There was a problem hiding this comment.
Should this be rolled into the main script?
There was a problem hiding this comment.
actually did this to make the scripts more clean, otherwise it ends up a big script which is a difficult process for a new contributor
There was a problem hiding this comment.
Maybe adding this as a lib to utils/ would reduce the clutter
it would be a stateless library along the lines of
deploy() returns (RegistryDeploymentLib.DeploymentData)
writeOutput(RegistryDeploymentLib.DeploymentData)
writeToRegistry(CoreDeploymentLib.DeploymentData, ICSDeploymentLib.DeploymentData)
And then it would add about 3 lines to the deploy script and would be useful to have in the tests where we just wouldn't write the json
There was a problem hiding this comment.
the struct is a bit overkill in this scenario since it's just a single address but i wanted to keep with the pattern from the other deployment libraries
| // #[tokio::test] | ||
| // async fn test_start_server() { | ||
| // let fake_aggregator = build_aggregator().await; | ||
| // let server = tokio::spawn(async move { | ||
| // let _ = | ||
| // FakeAggregator::start_server(Arc::new(tokio::sync::Mutex::new(fake_aggregator))) | ||
| // .await; | ||
| // }) | ||
| // .await; | ||
| // drop(server); | ||
| // } |
There was a problem hiding this comment.
this commented code can be deleted
