-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove the need of ecdsa key by default #120
Open
shrimalmadhur
wants to merge
5
commits into
master
Choose a base branch
from
madhur/remove-ecdsa-as-requirement
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianoaix
reviewed
Apr 24, 2024
ian-shim
reviewed
Apr 24, 2024
@@ -89,13 +94,15 @@ NODE_DB_PATH_HOST=${EIGENDA_HOME}/db | |||
NODE_CACHE_PATH_HOST=${USER_HOME}/eigenda-operator-setup/resources/cache | |||
|
|||
# TODO: Operators need to update this to their own keys | |||
NODE_ECDSA_KEY_FILE_HOST=${EIGENLAYER_HOME}/operator_keys/opr.ecdsa.key.json | |||
# Uncomment NODE_ECDSA_KEY_FILE_HOST if your need access to ecdsa key. This is generally not recommended | |||
# NODE_ECDSA_KEY_FILE_HOST=${EIGENLAYER_HOME}/operator_keys/opr.ecdsa.key.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still generate this key in EigenLayer cli by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by default we don't generate any key - they can generate or not but - it's not them.
jianoaix
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also changes interfaces for all operations.
Note: Same
.env
file is being used for these operations and running node. Even though only few variables are needed from the.env
files forrun.sh
script, to have minimal change I want to keep.env
for this too. But this is debatable if we want to remove.env
file forrun.sh
we have to make everything as argument and also need to make surenodeplugin
doesn't require any unnecessary fields from.env
fileOpt In
Opt out
List Quorums
Update socket
TODO