🚧 Fix some minor issues with build-lz-options #321
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryandgoulding
previously approved these changes
Jan 31, 2024
janjakubnanista
force-pushed
the
build-lz-options-fixes
branch
2 times, most recently
from
f9e8172
to
a3e7eee
Compare
|
Closing in favor of a smaller #329 - the native bindings issue (just a console warning) turns out to be more work than it's worth. Will be addressed later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
build-lz-optionsREADMEbuild-lz-optionssince we were getting warnings forbigint-buffersee issue here. For this, a newio-devtoolsfunction has been introduced -withMutedConsoleand the code that importslz-v2-utilitieshas been wrapped in an asyncimport