Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow returning string on getCurrentEntryId() #5746

Merged

Conversation

Chemaclass
Copy link
Contributor

WHY

BEFORE - What was wrong? What was happening before this PR?

The current PHPDoc works only when using int IDs
But uuid and ulids are strings

AFTER - What is happening after this PR?

the returning type is correct, allowing also to return string (additional to the previous types)

HOW

How did you achieve that, in technical terms?

Updating the phpdoc

Is it a breaking change?

no

uuid/ulid are string based not int
Copy link

welcome bot commented Jan 14, 2025

BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly.

Please keep in mind that:

  • if this constitutes a breaking change, it might take quite a while for this to get merged; we try to emulate the Laravel release cycle as much as possible, so developers can upgrade both software once; this means a new big release every ~6 months;
  • even if it's a non-breaking change, it might take a few days/weeks for the PR to get merged; unless it's a no-brainer, we like to have some community feedback on new features, before we merge them; this leads to higher-quality code, in the end; we learnt this the hard way :-)
  • not all PRs get merged; sometimes we just have to hold out new features, to keep the packages lean; sometimes we don't include features that only apply to niche use cases;
  • we're not perfect; if you think we're wrong, call us out on it; but in a kind way :-) we all make mistakes, best we learn from them and build better software together;

Thank you!

--
Justin Case
The Backpack Robot

@pxpm pxpm merged commit 06c7446 into Laravel-Backpack:main Jan 22, 2025
2 of 3 checks passed
Copy link

welcome bot commented Jan 22, 2025

WHOOP-WHOOP! Congrats, your first PR on this repo has officially been merged.

party

You should also receive an email inviting you to the Community Members team. That's where we, committed community members, debate new features and decide what's in the Backpack roadmap. Feel free to ignore the invitation if you're not interested :-)

If you want to help out the community in other ways, you can:

  • give your opinion on other GitHub Issues & PRs;
  • chat with others in the Gitter Chatroom (usually for quick help: How do I do X);
  • answer Backpack questions on Stackoverflow; you get points, people get help; you can subscribe to the backpack-for-laravel tag by adding a new filter; that will send you emails when new questions come up with our tag;

Again. Thank you for the PR. You are a wonderful person. Keep 'em coming :-)
Cheers!

--
Justin Case
The Backpack Robot

@Chemaclass Chemaclass deleted the feat/getCurrentEntryId-allow-string branch January 22, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants