This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
Fixed crashes related to disabling Cloth in the config. Also fixed and added some descriptive text. #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d added some descriptive text.
|
Oh, and I also found and fixed another crash/issue where the table UI for chainmail pieces weren't being set up when cloth was enabled because the part that switched those on was testing for the cloth config setting and not the chainmail config setting. |
|
thought id also mention, this also causes an error in the book when cloth armour is also disabled, the entry pages for them instead of just being removed, become pages of errors. i tried to fix this myself but unsure how to do it lol. |
This was referenced Jul 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you turned cloth off previously, it would result in an issue with the representation of all cloth items not being able to access white wool, which was the default item it was represented in JEI/creative inventory with. This corrects that crash by using an if-statement to switch the default item if cloth is not enabled.
I also added some language fields as well as some descriptive text for items that didn't have it yet.
Cheers!