Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a bug in which duplicate entries were not always filtered out.
This pull request involves changes to the
DataProviderManager
class insrc/lib/DataProviderManager.ts
and theMockProvider3
class intest/DataProviderManager-merge.test.ts
. The changes primarily aim to refine the logic for adding estimates and expand the test data for theMockProvider3
class.Here are the key changes:
Changes to
DataProviderManager
class:src/lib/DataProviderManager.ts
: The logic for adding estimates has been simplified. The condition for adding an estimate now only checks if the current estimate is lower than the minimum of all existing estimates. The check for the absence ofmergedEstimates[key]
and the presence ofestimates[key]
has been removed. This change streamlines the logic and potentially improves the efficiency of the function.Changes to
MockProvider3
class:test/DataProviderManager-merge.test.ts
: Additional test data has been added to theMockProvider3
class. Specifically, data points with keys "6" and "7" have been added to thegetAllData
method. This expanded test data can provide a more comprehensive evaluation of theDataProviderManager
's functionality. [1] [2]