-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mesh partitioning tool #1213
base: develop
Are you sure you want to change the base?
Conversation
/style |
add_executable(partitioner partitioner.cpp) | ||
target_link_libraries(partitioner PUBLIC serac_mesh) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add_executable(partitioner partitioner.cpp) | |
target_link_libraries(partitioner PUBLIC serac_mesh) | |
blt_add_executable(NAME partitioner | |
SOURCES partitioner.cpp | |
DEPENDS_ON serac_mesh) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the difference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, not much but it keeps it consistent with the rest of the code.
Should we have a "tools" directory for things of this flavor? I think this is the first one. |
wrong button sorry. |
I don't understand why, but one of the CI jobs is concluding that this code is unsafe because of a null pointer dereference(?): std::vector< uint32_t > blocks(num_blocks + 1);
blocks[0] = 0; Any idea how to work around this? It seems like a false positive to me. |
I agree that seems to be a false positive. Have you tried converting num_blocks to |
/style |
Where does this executable live? How does one know where to get it. I do thing something like an tool, or utilities, or apps directory for these kinds of things might make sense. |
I believe CMake puts executables in
I agree, although I think it makes more sense to worry about organization if/when we have more than 1. |
This PR comes from a request by @sethwatts on behalf of the digital twins project. It adds a new command line program that reads in an mfem mesh, partitions it into some number of pieces, and writes out those pieces to separate files.