Bugfix/talamini/thermomechanics with state #1181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r internal heat source Using a material doesn't work, because the source term contribution is meant to be the heat capacity, and hence gets multiplied by the temperature rate in the residual. With a custom integral, we can hopefully plug the internal heat source into the appropriate slot in functional and get the right result.
…om:LLNL/serac into bugfix/talamini/thermomechanics_with_state
…ability of solver output
I moved the update of the plastic work before the plasticity solve. This makes the logic of the model simpler.
Temeprature change test with thermoelastic Green-St Venant material.
Dummy material with constant heat source.
|
/style |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR contains a breaking change. I'm not sure if we should merge or not. Please help in evaluating that, and please don't merge this until we come to a decision.
Our thermomechanics physics module did not account for self-heating due to internal dissipation. The material model interface does return the internal dissipation, but it had nowhere to go in the heat transfer residual. This PR adds in this missing effect.
The breaking change is that the heat transfer module now has internal state variables (that is, quadrature point data). The mechanics module has this design, but the heat transfer currently does not. Should the this facet of design be symmetric between physics modules? If so, should it be moved into the base class, to avoid manual repetition?