Apply suggestions from code review

Co-authored-by: Tom Benson <[email protected]>
LLNL · Sep 24, 2024 · 5acdc25 · 5acdc25
1 parent 008e912
commit 5acdc25
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -920,7 +920,6 @@ add_subdirectory(applications/CANDLE/pilot2/tools)
 add_subdirectory(applications/ATOM/utils)
 add_subdirectory(tests)
 add_subdirectory(scripts)
-add_subdirectory(core-driver)
 
 ################################################################
 # Install LBANN

diff --git a/core-driver/CMakeLists.txt b/core-driver/CMakeLists.txt
@@ -1,7 +1,6 @@
 cmake_minimum_required(VERSION 3.21.0)
-project(my_lbann_test CXX)
+project(lbann-test-driver CXX)
 find_package(LBANN 0.102.0 REQUIRED)
-find_package(Conduit CONFIG REQUIRED)
 add_executable(lbann-core main.cpp)
 target_link_libraries(lbann-core PRIVATE LBANN::lbann)
 

diff --git a/include/lbann/data_ingestion/readers/data_reader_conduit.hpp b/include/lbann/data_ingestion/readers/data_reader_conduit.hpp
@@ -61,7 +61,7 @@ class conduit_data_reader : public generic_data_reader
     return label_size;
   }
 
-protected:
+private:
   std::vector<int> m_data_dims;
   std::vector<int> m_label_dims;