Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a configured header instead of relying on cmake defines #41

Open
adayton1 opened this issue Jul 31, 2020 · 1 comment
Open

Add a configured header instead of relying on cmake defines #41

adayton1 opened this issue Jul 31, 2020 · 1 comment

Comments

@adayton1
Copy link
Member

adayton1 commented Jul 31, 2020

In umpire, after importing camp using find_package, this bit of cmake is required to get a CUDA build of umpire working:

blt_add_target_definitions(
      TO camp
      SCOPE INTERFACE
      TARGET_DEFINITIONS CAMP_HAVE_CUDA)

Could we add a configurable header that handles this issue and precludes inconsistency across projects using camp?

@davidbeckingsale
Copy link
Member

Just for a bit more context, the CAMP_HAVE_CUDA macro is automatically defined when using nvcc:

#define CAMP_DEVICE __device__

However, in Umpire we are only linking to the CUDA runtime since we don't actually have device code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants