Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake ENABLE_TARGET_OPENMP doesn't actually enable OpenMP resources #81

Closed
abbotts opened this issue Aug 26, 2021 · 4 comments
Closed

Comments

@abbotts
Copy link

abbotts commented Aug 26, 2021

The CMake -DENABLE_TARGET_OPENMP flag doesn't look like it actually has any effect. Although this define has the same name, there isn't actually any CMake machinery to turn the config flag into the CPP define

#if defined(ENABLE_TARGET_OPENMP)

I think this is the root cause of LLNL/RAJA#1111

Because CAMP's build is so bare-bones I don't see an easy solution that I can just implement quickly, other than backout out #46 (which seems like it would break something else). The proper solution would probably involve #41 and some machinery to add OpenMP flags.

@trws
Copy link
Member

trws commented Aug 26, 2021

If you have a look in the ci-all-the-things branch, you'll find the version I'm working on to build with BLT, which should fix that. That should upstream shortly once I get the last of the clang bugs on the azure pipeline squashed out of it.

@abbotts
Copy link
Author

abbotts commented Aug 26, 2021

ci-all-the-things does add -fopenmp with -DENABLE_OPENMP via blt, which is a step forward. I don't think it solves the ENABLE_TARGET_OPENMP problem yet, though.

@abbotts
Copy link
Author

abbotts commented Aug 29, 2022

This CPP define is now CAMP_ENABLE_TARGET_OPENMP, and is correctly set by the CMake define of the same name, so this issue is fixed.

@abbotts abbotts closed this as completed Aug 29, 2022
@barracuda156
Copy link

@abbotts Apparently not: LLNL/CHAI#231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants