Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'cam_note' and 'tel_note' to command payloads #164

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

timbeccue
Copy link
Collaborator

The cam_note already existed under a different name, so I renamed those occurrences.
I added tel_note to the telescope command tab.

  • cam_note and tel_note are both keys in the optional_params dict that is part of the command payload
  • they are not included if the value is an empty string
  • tel_note is only considered if the mount command is the ‘go’ command (all green circled buttons in the attached screenshot). tel_note is never included for the other mount commands (red circled buttons in screenshot) like park, slew to flat position, etc.
Screenshot 2024-10-08 at 7 06 30 PM

@timbeccue timbeccue marked this pull request as ready for review October 9, 2024 00:53
@wrosing
Copy link

wrosing commented Oct 9, 2024 via email

@timbeccue timbeccue merged commit a9680bb into dev Oct 9, 2024
1 check passed
@timbeccue timbeccue deleted the feature/command_notes branch October 9, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants