-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Requests: project inputs, generic filters, observing mode #161
Conversation
Note: the generic filters list is used in both CreateProjectForm.vue and Camera.vue. This should be consolidated into a single location eventually so we have a single source of truth.
Add value: engineering Change display so that 'active' shows 'Online' and 'inactive' shows 'Offline'
b268e6b
to
a4e68c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just one comment on the list of modes - he wanted engineering included, too
@@ -29,9 +29,19 @@ const owmActive = (state, getters) => { | |||
} | |||
|
|||
const observingMode = (state, getters) => { | |||
let observingModeDisplay = state.wema_settings.observing_mode ?? 'n/a' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
He also talked to me about adding 'Engineering' as the display and sending the string 'engineering' - though his code cannot yet recognize it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is actually just for handling the status display, specifically translating between 'active'<-->'Online' and 'inactive'<-->'Offline'.
The 'engineering' status doesn't need this and so it's not included here, but I added it as an option for the user to select in Enclosure.vue
Adding some changes on Wayne's request:
Update the values in the projects->exposures->zoom select to be:
Generic filters: after lrgb, add ‘UV’, ‘IR Block’, DUO’
Expand RA/Dec inputs in projects so they don't truncate the values in sexagesimal form
Modify 'Observing Mode' in the enclosure control tab: