UI Requests: project inputs, generic filters, observing mode #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: the generic filters list is used in both CreateProjectForm.vue and Camera.vue. This should be consolidated into a single location eventually so we have a single source of truth.
mgdaily
approved these changes
Sep 9, 2024
Add value: engineering Change display so that 'active' shows 'Online' and 'inactive' shows 'Offline'
timbeccue
force-pushed
the
feature/wayne-project-ui-requests
branch
from
b268e6b
to
a4e68c6
Compare
mgdaily
approved these changes
Sep 9, 2024
| @@ -29,9 +29,19 @@ const owmActive = (state, getters) => { | |||
| } | |||
|
|
|||
| const observingMode = (state, getters) => { | |||
| let observingModeDisplay = state.wema_settings.observing_mode ?? 'n/a' | |||
There was a problem hiding this comment.
He also talked to me about adding 'Engineering' as the display and sending the string 'engineering' - though his code cannot yet recognize it.
There was a problem hiding this comment.
This part is actually just for handling the status display, specifically translating between 'active'<-->'Online' and 'inactive'<-->'Offline'.
The 'engineering' status doesn't need this and so it's not included here, but I added it as an option for the user to select in Enclosure.vue
timbeccue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some changes on Wayne's request:
Update the values in the projects->exposures->zoom select to be:
Generic filters: after lrgb, add ‘UV’, ‘IR Block’, DUO’
Expand RA/Dec inputs in projects so they don't truncate the values in sexagesimal form
Modify 'Observing Mode' in the enclosure control tab: