Reload an operation when it no longer exists in the cache #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LTDakin
reviewed
Sep 16, 2024
| instance = self.get_object() | ||
| serializer = self.get_serializer(instance) | ||
| if instance.status == 'PENDING' and not instance.output: | ||
| operation = available_operations().get(instance.name)(instance.input_data) |
There was a problem hiding this comment.
if an operation is retried but its inputs don't exist yet (because they're also being recreated). Would have to wait or know somehow when the input_data is ready
There was a problem hiding this comment.
Yeah I guess in our current system it would "Fail" if the inputs didn't exist at that moment and then be removed from the UI so that isn't great. I was trying to avoid making the getting operation logic more complicated to the point where it checks previous operations being done before attempting, but maybe that is the way to go.
There was a problem hiding this comment.
this kinda ties in to the original plan of having recipes that are saved, thats a whole 'nother can of worms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This worked for my old operations that were based on the input images. For operations based on the output of other earlier operations this didn't work, but its not clear to me why yet... Ideally the file basenames those operations reference will be the same as the one the earlier operations regenerate since they come from the cache_key which shouldn't change.