Add Gateway listeners support and new test #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azgabur
force-pushed
the
gateway_listeners
branch
from
a797fa2 to
32e4cd9
Compare
azgabur
force-pushed
the
gateway_listeners
branch
from
32e4cd9 to
8f13f3b
Compare
trepel
requested changes
Sep 13, 2024
testsuite/tests/singlecluster/gateway/reconciliation/listeners/test_gateway_listeners_dns.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/listeners/test_gateway_basic_listeners.py
Outdated
Show resolved
Hide resolved
trepel
reviewed
Sep 13, 2024
testsuite/tests/singlecluster/gateway/reconciliation/listeners/test_gateway_basic_listeners.py
Outdated
Show resolved
Hide resolved
azgabur
force-pushed
the
gateway_listeners
branch
3 times, most recently
from
c612ee5 to
9d946c5
Compare
trepel
previously approved these changes
Sep 17, 2024
azgabur
force-pushed
the
gateway_listeners
branch
2 times, most recently
from
15744b6 to
c6e56e3
Compare
|
^ Rebased due to #520 merging |
trepel
previously approved these changes
Sep 17, 2024
azgabur
force-pushed
the
gateway_listeners
branch
from
c6e56e3 to
9408fbf
Compare
|
^ Add forgotten |
Hupst, I missed this.
2nd hupst, I missed this Anyway, I ran |
trepel
previously approved these changes
Sep 17, 2024
jsmolar
reviewed
Sep 18, 2024
jsmolar
reviewed
Sep 18, 2024
averevki
reviewed
Sep 18, 2024
testsuite/tests/singlecluster/gateway/reconciliation/listeners/conftest.py
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/listeners/conftest.py
Outdated
Show resolved
Hide resolved
azgabur
force-pushed
the
gateway_listeners
branch
from
9408fbf to
440faf6
Compare
|
^ Rebase and incorporate feedback |
|
Acceptance failing because of #543 |
azgabur
force-pushed
the
gateway_listeners
branch
from
440faf6 to
310d098
Compare
Signed-off-by: Alex Zgabur <[email protected]>
azgabur
force-pushed
the
gateway_listeners
branch
from
310d098 to
cc38bb6
Compare
Signed-off-by: Alex Zgabur <[email protected]>
azgabur
force-pushed
the
gateway_listeners
branch
from
cc38bb6 to
974a27e
Compare
jsmolar
reviewed
Oct 15, 2024
averevki
approved these changes
Oct 16, 2024
jsmolar
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #308
Refactors test from previous PR Add Gateway listener dns test #504 to add support for new listeners gateway functions and e2e check for domain missing error.
Add function to return TTL value from DNSRecord CR corresponding with listener in Gateway, can be used to wait for DNS updates.
Add new test for adding/removing listeners from Gateway
These current PR's will need to be rebased to use new listeners support @averevki (or I will rebase this PR if these PR's will get merged first)
To verify the new tests run:
Due to changes to Gateway creation a full testsuite run should be performed as well.