Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Hostname if external IP is not found #505

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

trepel
Copy link
Contributor

@trepel trepel commented Aug 12, 2024

Overview

Openshift Service resource of LoadBalancer type might have EXTERNAL-IP in form of standartd static IP or in form of hostname

See

$ oc get service keycloak -n tools
NAME       TYPE           CLUSTER-IP       EXTERNAL-IP    PORT(S)          AGE
keycloak   LoadBalancer   172.30.137.193   10.0.190.138   8080:31556/TCP   13d

versus

$ oc get service keycloak -n tools
NAME       TYPE           CLUSTER-IP      EXTERNAL-IP                                                               PORT(S)          AGE
keycloak   LoadBalancer   172.30.56.116   a9b2f08c4b3154094ae774fbcbb2e642-1403130510.us-west-2.elb.amazonaws.com   8080:32470/TCP   42m

This PR should allow the testsuite to work if EXTERNAL-IP is configured either way.

Verification Steps

Eye review. You can run a single test that uses keycloak against a cluster backed by Openstack (such clusters use static IP approach) and against another cluster backed by AWS (hostname approach).

@trepel trepel force-pushed the hostname-if-no-external-ip branch from 653ea2f to a12e220 Compare August 12, 2024 08:38
@trepel trepel requested a review from ficap August 12, 2024 11:00
@averevki averevki merged commit 07e9d84 into Kuadrant:main Aug 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants