Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redundant kuadrant fixture #342

Merged
merged 2 commits into from
Feb 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions testsuite/tests/kuadrant/gateway/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,6 @@
from testsuite.policy.authorization.auth_policy import AuthPolicy


@pytest.fixture(scope="module")
def kuadrant(kuadrant):
"""Skip if not running on Kuadrant"""
if not kuadrant:
pytest.skip("Gateway tests are only for Kuadrant")
return kuadrant


@pytest.fixture(scope="module")
def gateway_ready(gateway):
"""Returns ready gateway"""
Expand Down
2 changes: 2 additions & 0 deletions testsuite/tests/kuadrant/gateway/test_basic.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

import pytest

pytestmark = [pytest.mark.kuadrant_only]


@pytest.fixture(scope="module")
def rate_limit():
Expand Down
8 changes: 0 additions & 8 deletions testsuite/tests/kuadrant/reconciliation/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,6 @@ def commit(request, authorization):
authorization.wait_for_ready()


@pytest.fixture(scope="module")
def kuadrant(kuadrant):
"""Skip if not running on Kuadrant"""
if not kuadrant:
pytest.skip("Reconciliation test can only be run on Kuadrant")
return kuadrant


@pytest.fixture(scope="module")
def resilient_request(client):
"""Fixture which allows to send retrying requests until the expected status code is returned"""
Expand Down
2 changes: 2 additions & 0 deletions testsuite/tests/kuadrant/test_rate_limit_anonymous.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
from testsuite.policy.authorization import Pattern, JsonResponse, ValueFrom
from testsuite.policy.rate_limit_policy import Limit

pytestmark = [pytest.mark.kuadrant_only, pytest.mark.limitador]


@pytest.fixture(scope="module")
def rate_limit(rate_limit):
Expand Down
Loading