Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always run Kuadrant check #340

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Always run Kuadrant check #340

merged 1 commit into from
Mar 6, 2024

Conversation

pehala
Copy link
Contributor

@pehala pehala commented Feb 7, 2024 •
edited
Loading

  • Run Kuadrant check every time in the beginning, unless there is a --standalone flag
  • make test now has --enforce flag
  • Run Kuadrant check against default cluster, if no spokes are configured

@pehala pehala marked this pull request as draft February 7, 2024 18:18
@pehala pehala force-pushed the fix_kuadrant_check branch from 6e514a4 to 93ffe2b Compare February 12, 2024 12:23
@pehala pehala marked this pull request as ready for review February 12, 2024 12:24
@pehala pehala changed the title Fix Kuadrant check when spokes are missing Always run Kuadrant check Feb 12, 2024
averevki
averevki reviewed Feb 15, 2024
View reviewed changes
testsuite/capabilities.py Outdated Show resolved Hide resolved
testsuite/tests/conftest.py Show resolved Hide resolved
testsuite/capabilities.py Outdated Show resolved Hide resolved
@pehala pehala force-pushed the fix_kuadrant_check branch from 93ffe2b to 4413ee8 Compare February 15, 2024 14:33
@pehala pehala force-pushed the fix_kuadrant_check branch from 4413ee8 to e1c957b Compare February 15, 2024 14:35
@pehala pehala requested a review from averevki February 15, 2024 14:38
@pehala pehala merged commit 3eb83fe into Kuadrant:main Mar 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averevki averevki averevki approved these changes

@jsmolar jsmolar jsmolar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pehala @jsmolar @averevki