Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RLP targetting tests #338

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Add RLP targetting tests #338

merged 2 commits into from
Mar 4, 2024

Conversation

jsmolar
Copy link

@jsmolar jsmolar commented Feb 7, 2024

This PR implements two use cases for RLP:

  1. Tests that when one limit is targeting two rules, the same limit applies for them both at once.
  2. Tests that when two limits are targeting one rule, one limit ends up shadowing others.

Test cases are points 5 and 6 from RFC. Please think of this cases, if they are meaningful or extendable.

@pehala pehala changed the title Added tests for RLP from RFC (5,6) Add RLP targetting tests Feb 8, 2024
@pehala pehala merged commit 5c71f7e into Kuadrant:main Mar 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pehala pehala pehala approved these changes

@martinhesko martinhesko martinhesko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsmolar @martinhesko @pehala