Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace standalone config option for --standalone flag #337

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

pehala
Copy link
Contributor

@pehala pehala commented Feb 7, 2024

Makes configuring standalone run to be all done through flags instead of config + flag

@pehala pehala requested a review from jsmolar February 7, 2024 14:39
@pehala pehala force-pushed the standalone-switch branch 2 times, most recently from 1ad6282 to 4a962e6 Compare February 7, 2024 14:53
azgabur
azgabur previously approved these changes Feb 7, 2024
Copy link
Contributor

@averevki averevki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like --standalone flag doing the same functionality as -m "not kuadrant_only". And still, it is only possible to use it with another "standalone" flag.

testsuite/tests/conftest.py Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
config/settings.local.yaml.tpl Show resolved Hide resolved
jsmolar
jsmolar previously approved these changes Feb 12, 2024
averevki
averevki previously approved these changes Feb 12, 2024
@pehala pehala dismissed stale reviews from averevki, jsmolar, and azgabur via cdd4fba February 12, 2024 11:59
@pehala pehala merged commit fbe3d4e into Kuadrant:main Feb 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants